[PATCH xserver] glamor: Clarify variable names in glamor_copy_cpu_fbo

Michel Dänzer michel at daenzer.net
Tue Jun 13 02:21:36 UTC 2017


On 13/06/17 09:50 AM, Keith Packard wrote:
> This function creates a temporary pixmap to hold data being moved from
> the source to the destination. However, it labeled all of the
> variables associated with this as src_, which makes it confusing to
> read the code. Rename them tmp_ instead. Also fix the comment
> describing the function to note that it copies from CPU to GPU, not
> GPU to GPU.
> 
> Signed-off-by: Keith Packard <keithp at keithp.com>

You'll need to rebase this onto my fix.

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the xorg-devel mailing list