[RFC xserver 05/16] DRI3/Glamor: Implement PixmapFromBuffers request
Daniel Stone
daniel at fooishbar.org
Fri Jun 9 12:22:16 UTC 2017
Hi Michel,
On 9 June 2017 at 03:36, Michel Dänzer <michel at daenzer.net> wrote:
> On 09/06/17 03:43 AM, Daniel Stone wrote:
>> @@ -66,7 +68,7 @@ typedef struct dri3_screen_info {
>> uint32_t version;
>>
>> dri3_open_proc open;
>> - dri3_pixmap_from_fd_proc pixmap_from_fd;
>> + dri3_pixmap_from_fds_proc pixmap_from_fds;
>> dri3_fd_from_pixmap_proc fd_from_pixmap;
>> dri3_get_formats_proc get_formats;
>> dri3_get_modifiers_proc get_modifiers;
>
> Completely dropping the pixmap_from_fd hook might be a bit harsh. It
> would mean drivers without pixmap_from_fds support (e.g.
> xf86-video-amdgpu/ati with EXA) can't support DRI3 at all, right?
Yeah, I think we'd missed that. It sounds like it'd be much better to
just add a new hook; this also makes the implementation patches split
out much more nicely, as the request handler and definitions can be
added completely separately to the Glamor support. Thanks for the
suggestion!
Cheers,
Daniel
More information about the xorg-devel
mailing list