[PATCH xrandr v2 1/2] xrandr: allow a single value for --scale

Giuseppe Bilotta giuseppe.bilotta at gmail.com
Sun Jul 16 12:55:28 UTC 2017


On Fri, Jul 14, 2017 at 2:46 AM, Aaron Plattner <aplattner at nvidia.com> wrote:
>> -.IP "\-\-scale \fIx\fPx\fIy\fP"
>> -Changes the dimensions of the output picture. Values superior to 1 will
>> lead to
>> +.IP "\-\-scale \fIx\fP[x\fIy\fP]"
>> +Changes the dimensions of the output picture. If the \fIy\fP value is
>> omitted,
>> +the \fIx\fP value will be used for both dimensions. Values superior to 1
>> will lead to
> I think "greater than" or "larger than" are more common than "superior to"
> for numerical comparisons, and new sentences in roff format are supposed to
> start on their own lines. I can send a separate change to fix those if you
> don't feel like fixing them as part of this change.

No problem. I'll respin the series to get the whitespace right in this patch,
and add a patch for the grammar fixes and newline-before-sentence
(there's a few plurals
in the rest of the paragraph that aren't very convincing either)

>>             if (sscanf (argv[i], "%lfx%lf", &sx, &sy) != 2)
>> -               argerr ("failed to parse '%s' as a scaling factor\n",
>> argv[i]);
>> +           {
>> +                   if (sscanf (argv[i], "%lf", &sx) != 1)
> This looks like it's indented too far. Should be two tabs and no spaces, and
> the next line should be two tabs and four spaces. Yes, this is terrible and
> I hate it. ;)

Let's see if I can get it right 8-)

Giuseppe "Oblomov" Bilotta

More information about the xorg-devel mailing list