[PATCH xserver 1/2] shm, xwayland: prefer atomic close-on-exec without O_TMPFILE

Julien Cristau jcristau at debian.org
Fri Jul 7 21:05:26 UTC 2017


On Fri, Jul  7, 2017 at 22:41:06 +0200, Jan Beich wrote:

> Julien Cristau <jcristau at debian.org> writes:
> 
> > On Fri, Jul  7, 2017 at 16:31:48 +0200, Jan Beich wrote:
> >> -	flags = fcntl(fd, F_GETFD);
> >> +#ifndef HAVE_MKOSTEMP
> >> +	int flags = fcntl(fd, F_GETFD);
> >
> > Do we allow mixed declarations and code nowadays?
> 
> xserver has quite a few of those already, even in Xext/shm.c e.g.,
> 
Those examples are all at the beginning of a block, so they don't count
:)

Anyway, I think
https://cgit.freedesktop.org/xorg/xserver/tree/doc/c-extensions#n35
answers my question, so it's fine.

Cheers,
Julien


More information about the xorg-devel mailing list