[PATCH xserver 0/4] os, glx: honor LIBGL_DRIVERS_PATH, and privilege checks

Nicolai Hähnle nhaehnle at gmail.com
Fri Jan 27 13:37:34 UTC 2017


Hi all,

the main point of this series is to take LIBGL_DRIVERS_PATH into account
when loading a DRI driver for libglx.

This is convenient for testing, and Glamor already does this anyway.
Unsurprisingly, dynamic linker mayhem tends to ensue when Glamor and libglx
load different drivers (or rather, different versions of the same driver),
so this is even somewhat of a bug fix.

Obviously, trusting LIBGL_DRIVERS_PATH is a bad idea when the X server is
installed setuid. While looking into how to test for that, I noticed that
different parts of the xserver do this test in different ways. So the first
three patches are about settling on the most thorough test that I found in
the current code.

Please review!

Thanks,
Nicolai
--
 glx/glxdricommon.c             | 38 ++++++++++++++++--
 hw/xfree86/common/xf86Config.c |  2 +-
 hw/xfree86/common/xf86Init.c   | 69 ++------------------------------
 hw/xfree86/common/xf86Priv.h   |  2 -
 include/os.h                   |  3 ++
 os/utils.c                     | 65 +++++++++++++++++++++++++++++-
 6 files changed, 105 insertions(+), 74 deletions(-)



More information about the xorg-devel mailing list