[PATCH 3/3 all repositories] autogen: Set a default subject prefix for patches

Peter Hutterer peter.hutterer at who-t.net
Tue Jan 24 02:57:01 UTC 2017


On Tue, Jan 24, 2017 at 02:35:34AM +0000, Emil Velikov wrote:
> On 24 January 2017 at 00:40, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> > From: Adam Jackson <ajax at redhat.com>
> >
> > Per discussion at XDC2015, we want this so we can easily distinguish
> > which module a patch is for. There's no way to set this in the
> > server-side config, so setting a default at autogen time is about the
> > best we can do.
> >
> > Reviewed-by: Eric Anholt <eric at anholt.net>
> > Signed-off-by: Adam Jackson <ajax at redhat.com>
> > Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> > ---
> >  autogen.sh | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/autogen.sh b/autogen.sh
> > index 0006de8..cda30cc 100755
> > --- a/autogen.sh
> > +++ b/autogen.sh
> > @@ -9,6 +9,9 @@ cd "$srcdir"
> >  autoreconf -v --install || exit 1
> >  cd "$ORIGDIR" || exit $?
> >
> > +git config --local --get format.subjectPrefix ||
> > +    git config --local format.subjectPrefix "PATCH bigreqsproto"
> Seems off, plus a simple basename `pwd` might not always work.

that's an artefact of the script I used here on the first repository, i.e.
it shows that it's working (I took this patchset from the bigreqsproto
repo). the prefix is hardcoded per repository. 

> Mihail Konev has a patch (message id
> <20161014000652.GA12465 at localhost>) which includes a tarball with all
> the patches.
> From a quick skim things seem ok - don't see anything wrong and/or
> missing. Fwiw I'd go with that one.

ok, I'll have a look at that one too then, thanks.

Cheers,
   Peter



> 
> The rest of the series is (fwiw)
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
> 
> Thanks !
> Emil


More information about the xorg-devel mailing list