[PATCH xserver] AttendClient of grab-pervious client should queue to saved_ready_clients

Adam Jackson ajax at nwnk.net
Wed Jan 11 19:45:33 UTC 2017


On Wed, 2017-01-11 at 09:02 -0800, Keith Packard wrote:
> Adam Jackson <ajax at nwnk.net> writes:
> 
> > 80 columns max, please.
> 
> Wrapped.

D'oh, this was in two places but I only commented on the one.

> > The conditional is always true, which makes me wonder what
> > conditional
> > you meant to write instead.
> 
> Good catch; I was just reading the cases where listen_to_client could
> return FALSE and yet the client should not be marked ready, and not
> looking at the line in AttendClient which was zeroing the
> COMM_IGNORED bit.
> 
> Here's a second version:

lgtm, merged:

remote: E: failed to find patch for rev 785053d033e73d2deb0ded4b97eabfd881991978.
remote: I: 0 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   436da93..785053d  master -> master

Patch not found in patchwork at minimum because I fixed up the long
comment line in include/dixstruct.h as well. Probably also because
patchwork sucks at patches sent as attachments.

We've got a few serious bugfixes in master since 1.19 at this point,
I'll cherry-pick those back and push out a 1.19.1.

- ajax


More information about the xorg-devel mailing list