[PATCH xserver] AttendClient of grab-pervious client should queue to saved_ready_clients

Adam Jackson ajax at nwnk.net
Wed Jan 11 16:45:48 UTC 2017


On Mon, 2017-01-09 at 18:14 -0800, Keith Packard wrote:

> +/* Client has requests queued or data on the network, but awaits a server grab release */

80 columns max, please.

> @@ -1067,6 +1067,10 @@ AttendClient(ClientPtr client)

Additional context here:

       oc->flags &= ~OS_COMM_IGNORED;
>      set_poll_client(client);
>      if (listen_to_client(client))
>          mark_client_ready(client);
> +    else if (!(oc->flags & OS_COMM_IGNORED)) {
> +        /* grab active, mark ready when grab goes away */
> +        mark_client_saved_ready(client);
> +    }
>  }

The conditional is always true, which makes me wonder what conditional
you meant to write instead.

- ajax


More information about the xorg-devel mailing list