[Mesa-dev] [PATCH] radv: fix depth transitions with layerCount = VK_REMAINING_ARRAY_LAYERS

[Bas Nieuwenhuizen]

Thanks, pushed.

- Bas

On Sat, Jan 7, 2017 at 12:08 AM, Pierre-Loup A. Griffais
<pgriffais at valvesoftware.com> wrote:
> Yep, sorry about that and thanks for the review... Please ignore the other
> thread on mesa-dev now that this one is in the right place :(
>
> On 01/06/2017 02:05 PM, Jason Ekstrand wrote:
>>
>> Bah... cc mesa-dev
>>
>> On Fri, Jan 6, 2017 at 2:04 PM, Jason Ekstrand <jason at jlekstrand.net
>> <mailto:jason at jlekstrand.net>> wrote:
>>
>>     Reviewed-by: Jason Ekstrand <jason at jlekstrand.net
>>     <mailto:jason at jlekstrand.net>>
>>
>>     I'll let Dave or Bas push though. :-)
>>
>>     On Fri, Jan 6, 2017 at 12:57 PM, Pierre-Loup A. Griffais
>>     <pgriffais at valvesoftware.com <mailto:pgriffais at valvesoftware.com>>
>>     wrote:
>>
>>         Interpreting layerCount literally would try to create billions
>>         of image
>>         views in radv_process_depth_image_inplace().
>>
>>         Signed-off-by: Pierre-Loup A. Griffais
>>         <pgriffais at valvesoftware.com <mailto:pgriffais at valvesoftware.com>>
>>         ---
>>          src/amd/vulkan/radv_meta_decompress.c | 2 +-
>>          1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>         diff --git a/src/amd/vulkan/radv_meta_decompress.c
>>         b/src/amd/vulkan/radv_meta_decompress.c
>>         index 47ef64d..9f262e6 100644
>>         --- a/src/amd/vulkan/radv_meta_decompress.c
>>         +++ b/src/amd/vulkan/radv_meta_decompress.c
>>         @@ -382,7 +382,7 @@ static void
>>         radv_process_depth_image_inplace(struct radv_cmd_buffer
>> *cmd_buffer,
>>
>>
>>         radv_meta_save_graphics_reset_vport_scissor(&saved_state,
>>         cmd_buffer);
>>
>>         -       for (uint32_t layer = 0; layer <
>>         subresourceRange->layerCount; layer++) {
>>         +       for (uint32_t layer = 0; layer <
>>         radv_get_layerCount(image, subresourceRange); layer++) {
>>                         struct radv_image_view iview;
>>
>>                         radv_image_view_init(&iview, cmd_buffer->device,
>>         --
>>         2.9.3
>>
>>         _______________________________________________
>>         xorg-devel at lists.x.org <mailto:xorg-devel at lists.x.org>: X.Org
>>         development
>>         Archives: http://lists.x.org/archives/xorg-devel
>>         <http://lists.x.org/archives/xorg-devel>
>>         Info: https://lists.x.org/mailman/listinfo/xorg-devel
>>         <https://lists.x.org/mailman/listinfo/xorg-devel>
>>
>>
>>
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev