[PATCH] modesetting: Fix 16 bit depth/bpp mode

[Adam Jackson]

On Thu, 2016-12-22 at 15:41 +0100, Stefan Agner wrote:
> When setting DefaultDepth to 16 in the Screen section, the current
> code requests a 32 bpp framebuffer, however the X-Server seems to
> assumes 16 bpp.
> 
> Fixes commit 21217d02168d ("modesetting: Implement 32->24 bpp
> conversion in shadow update")
> 
> Signed-off-by: Stefan Agner <stefan at agner.ch>
> ---
> Observed this issue using X-Server/modesetting 1.18.4 and the FSL
> DCU DRM driver, but I am pretty sure it is driver independent. Not
> sure if the change is properly taking care of the corner case which
> was initially targetted, but it makes specifiying DefaultDepth with
> values of 16/24/32 and not specifiying it work for me.

Without this patch, what path do you end up taking through
drmmode_get_default_bpp() ? I'm a little suspicious of the error
handling in that function.

- ajax