[PATCH xserver 01/10] tests: Refactor wraps into protocol-common.c

Adam Jackson ajax at redhat.com
Mon Jan 2 17:16:34 UTC 2017


On Fri, 2016-12-30 at 13:30 +0500, Mihail Konev wrote:
> This is to prepare for joining test/xi2/protocol-* into a single
> binary.
> 
> Signed-off-by: Mihail Konev <k.mvc at ya.ru>

This breaks 'make check' for me:

../../test-driver: line 107: 28911 Segmentation faultĀ (core dumped) "$@" > $log_file 2>&1
FAIL: protocol-xipassivegrabdevice

gdb says:

Program received signal SIGSEGV, Segmentation fault.
WriteToClient (who=0x8160a0 <client_request>, count=32, __buf=0x7fffffffde80) at io.c:661
661	    oco = oc->output;
(gdb) bt
#0  WriteToClient (who=0x8160a0 <client_request>, count=32, __buf=0x7fffffffde80) at io.c:661
#1  0x00000000004f627c in ProcXIPassiveGrabDevice (client=client at entry=0x8160a0 <client_request>) at xipassivegrab.c:231
#2  0x000000000040da61 in request_XIPassiveGrabDevice (error=error at entry=0, errval=errval at entry=0, client=0x8160a0 <client_request>, req=0x80e0a0 <data>) at protocol-xipassivegrabdevice.c:129
#3  0x000000000040ce56 in test_XIPassiveGrabDevice () at protocol-xipassivegrabdevice.c:225
#4  main (argc=<optimized out>, argv=<optimized out>) at protocol-xipassivegrabdevice.c:245

I think the new LDFLAGS for this test is missing a -Wl,-wrap,WriteToClient.

- ajax


More information about the xorg-devel mailing list