[PATCH RFC xserver] os: Add a mutex to protect io buffers

Alan Coopersmith alan.coopersmith at oracle.com
Wed Feb 22 23:46:51 UTC 2017


On 02/22/17 03:20 PM, Keith Packard wrote:
> Adam Jackson <ajax at nwnk.net> writes:
>
>> On Wed, 2017-02-22 at 16:50 +0100, Olivier Fourdan wrote:
>>> WriteToClient() can be called from XIChangeDeviceProperty() so from the
>>> InputThread which is a problem as it allocates and free the input and
>>> output buffers.
>
> That seems like a bug to me; the input thread isn't supposed to be
> directly interacting with clients. Instead, it should queue a suitable
> work proc and have the events delivered from there. This will ensure
> proper serialization with request processing so that the right serial
> numbers and other data are inserted.

Should WriteToClient() have something like
	assert(pthread_self() == mainThread)
added to help catch things like that?

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list