xserver 1.19.2 call for patches

[Michel Dänzer]

On 20/02/17 06:44 PM, Olivier Fourdan wrote:
> ----- Original Message -----
>> I'd like to do another 1.19 soonish, say middle of next week.
> 
> That would be great if we could get to the bottom of the random
> crashes that affect 1.19.x first.
> 
> Good news is we now have a core file from downstream bug
> https://bugzilla.redhat.com/show_bug.cgi?id=1424644
> 
> I'm struggling to find the problem so if anyone else has any idea,
> I'm all hear.

I also got stuck analyzing the valgrind logs in
https://bugs.freedesktop.org/show_bug.cgi?id=99164 .

One thing that confuses me in the valgrind output below is:
CloseDownConnection (connection.c:919) seems to refer to the
FreeOsBuffers call (specifically, the free(oco) in there). However,
FreeOsBuffers is defined in io.c, so why does the valgrind output look
as if FreeOsBuffers was inlined into CloseDownConnection? Is there some
kind of LTO going on, or are there any patches affecting this applied on
top of upstream?


==6926== Invalid read of size 8
==6926==    at 0x58ECDC: WriteToClient (io.c:705)
==6926==    by 0x440C81: WriteEventsToClient (events.c:6000)
==6926==    by 0x440E82: TryClientEvents (events.c:2021)
==6926==    by 0x4445C0: DeliverEventToInputClients (events.c:2170)
==6926==    by 0x4448BB: DeliverEventToWindowMask (events.c:2213)
==6926==    by 0x4448BB: DeliverEventsToWindow (events.c:2277)
==6926==    by 0x445065: DeliverEvents (events.c:2826)
==6926==    by 0x464182: DeleteWindow (window.c:1096)
==6926==    by 0x459C11: doFreeResource (resource.c:880)
==6926==    by 0x45ADBB: FreeClientResources (resource.c:1146)
==6926==    by 0x434ADE: CloseDownClient (dispatch.c:3464)
==6926==    by 0x58FDE0: ospoll_wait (ospoll.c:412)
==6926==    by 0x589112: WaitForSomething (WaitFor.c:226)
==6926==  Address 0x19eb2960 is 0 bytes inside a block of size 24 free'd
==6926==    at 0x4C2D12B: free (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==6926==    by 0x58C58E: CloseDownConnection (connection.c:919)
==6926==    by 0x434C25: CloseDownClient (dispatch.c:3438)
==6926==    by 0x58FDE0: ospoll_wait (ospoll.c:412)
==6926==    by 0x589112: WaitForSomething (WaitFor.c:226)
==6926==    by 0x4354F0: Dispatch (dispatch.c:412)
==6926==    by 0x4397F7: dix_main (main.c:287)
==6926==    by 0x6ADA67F: (below main) (libc-start.c:289)
==6926==  Block was alloc'd at
==6926==    at 0x4C2BEFF: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==6926==    by 0x58ED1B: AllocateOutputBuffer (io.c:975)
==6926==    by 0x58ED1B: WriteToClient (io.c:707)
==6926==    by 0x43536A: SendConnSetup (dispatch.c:3668)
==6926==    by 0x43536A: ProcEstablishConnection (dispatch.c:3706)
==6926==    by 0x4356BA: Dispatch (dispatch.c:469)
==6926==    by 0x4397F7: dix_main (main.c:287)
==6926==    by 0x6ADA67F: (below main) (libc-start.c:289)


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer