[PATCH xserver 4/7] xfree86: Remove Option "BiosBase"

[Adam Jackson]

On Tue, 2017-02-14 at 13:39 -0800, Aaron Plattner wrote:
> On 02/14/2017 12:30 PM, Adam Jackson wrote:
> > 
> > diff --git a/hw/xfree86/parser/xf86tokens.h b/hw/xfree86/parser/xf86tokens.h
> > index 15792c6..4aa17a7 100644
> > --- a/hw/xfree86/parser/xf86tokens.h
> > +++ b/hw/xfree86/parser/xf86tokens.h
> > @@ -181,7 +181,6 @@ typedef enum {
> >      IOBASE,
> >      RAMDAC,
> >      DACSPEED,
> > -    BIOSBASE,
> 
> I really hope no configurations are actually using this keyword, but if 
> they are, this will break them. Fine with me, as long as that's intentional.

Mmm. AFAICT the keyword stuff here is a legacy of trying to be
compatible with XFree86 3.x configs, which didn't have the Option
syntax. Given there are only two drivers that would honor whatever
value you'd set - both of which normally DTRT from PCI configuration -
I don't imagine anyone is relying on this keyword actually taking
effect. But you're right, this would turn a no-op into a parse error,
that's not cool.

I'll drop the keyword bits when merging this, thanks for the catch.

- ajax