[PATCH xserver] xwayland: replace hardcoded function name with __func__ in error msg

Olivier Fourdan ofourdan at redhat.com
Wed Feb 8 07:46:16 UTC 2017


Hey Peter,

> > LGTM - Yo get rid of two \n along the way, but I think there were not
> > needed in the first place so:
> 
> oops. no, they're neeed so I added them back (and also to the instance where
> it was missing). thanks

Are they really needed? I looked at ErrorF() in the source tree and there are plenty of cases where there is no \n at the end, so I looked at LogVMessageVerb() where ErrorF() should end up, and it seemed to me it would ad it if missing:

https://cgit.freedesktop.org/xorg/xserver/tree/os/log.c#n702

Anyway, it's no big deal :)

Cheers,
Olivier


More information about the xorg-devel mailing list