[PATCH] glx: do not pick sRGB config for 32-bit RGBA visual
Tapani Pälli
tapani.palli at intel.com
Mon Dec 11 05:53:11 UTC 2017
Hi;
Any comments? Without this change there will be issues with certain
Linux desktops when distributions start to use Mesa 17.4.
On 11/28/2017 09:23 AM, Tapani Pälli wrote:
> This fixes blending issues seen with kwin and gnome-shell when
> 32bit visual has sRGB capability set.
>
> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103699
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103646
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103655
> ---
> glx/glxscreens.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/glx/glxscreens.c b/glx/glxscreens.c
> index 73444152a..596d972e0 100644
> --- a/glx/glxscreens.c
> +++ b/glx/glxscreens.c
> @@ -271,6 +271,11 @@ pickFBConfig(__GLXscreen * pGlxScreen, VisualPtr visual)
> /* If it's the 32-bit RGBA visual, demand a 32-bit fbconfig. */
> if (visual->nplanes == 32 && config->rgbBits != 32)
> continue;
> + /* If it's the 32-bit RGBA visual, do not pick sRGB capable config.
> + * This can cause issues with compositors that are not sRGB aware.
> + */
> + if (visual->nplanes == 32 && config->sRGBCapable == GL_TRUE)
> + continue;
> /* Can't use the same FBconfig for multiple X visuals. I think. */
> if (config->visualID != 0)
> continue;
>
More information about the xorg-devel
mailing list