[PATCH xserver 2/2] glamor: Avoid overflow between box32 and box16 box

Keith Packard keithp at keithp.com
Mon Aug 28 16:34:10 UTC 2017

Olivier Fourdan <ofourdan at redhat.com> writes:

> Sorry for the delay, I was on PTO... 
> What I observed is that the issue occurs because temp_box.x2 is 32768:
> https://bugs.freedesktop.org/show_bug.cgi?id=101894#c6

oh, that can happen if repeate_type is not RepeatNone, is that the case
here? I'm just trying to make sure we don't have pixmaps larger than
32767 sneaking through somehow, which would be bad in all kinds of

In any case, we still need this check to avoid the problem:

Reviewed-by: Keith Packard <keithp at keithp.com>

(someday we may just have to switch to 32-bit regions...)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20170828/e2d5818b/attachment.sig>

More information about the xorg-devel mailing list