[PATCH] xwayland: Avoid repeatedly looping through window ancestor chain

Roman Gilg subdiff at gmail.com
Tue Aug 22 13:48:47 UTC 2017

I've just sent another version with different naming and the additional
function for comparing the private field's xwl_window with its creator as
reply to your mail. Take a look how you like it. One other difference: I
realized that the xwl_window_find(..) function is unneeded, since when
putting the xwl_window always in the private field, we can just on
Realization take the one of its parent window.

On Mon, Aug 14, 2017 at 11:33 AM, Pekka Paalanen <ppaalanen at gmail.com>
> How does your Present and sub-surface work change the relationships
> between Windows and xwl_windows? Does the child Window getting a
> sub-surface have its own xwl_window? Are there cases for fetching from
> the child Window (or from its descendant) both its own xwl_window and
> the respective toplevel Window's xwl_window?

Currently I always use the xwl_window of the ancestor like it's right now.
That means that in one ancestor chain originating from the top xwl_window
only one of the windows can use the Present extension at one point in time.
But I assume that's sufficient for most use cases. Introducing another
struct for allowing flips also for windows without owning an xwl_window
could be an improvement in the future though.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.x.org/archives/xorg-devel/attachments/20170822/15362a0b/attachment.html>

More information about the xorg-devel mailing list