[PATCH xserver 2/3] glx: Inline some reply swapping code

Adam Jackson ajax at redhat.com
Fri Aug 18 16:52:39 UTC 2017


On Wed, 2017-08-16 at 15:00 -0700, Keith Packard wrote:
> Adam Jackson <ajax at redhat.com> writes:
> 
> > Signed-off-by: Adam Jackson <ajax at redhat.com>
> 
> Why? I can see removing the WriteToClient calls from the functions, but
> any particular reason to inline them?

Consistency and cleanliness? They're the only out-of-lined reply swap
functions which puts them solidly in the minority (seven out of GLX's
32ish replies), and glxserver.h is currently kind of a misc-and-other
header that I was trying to give some focus.

- ajax


More information about the xorg-devel mailing list