[PATCH xserver v2] meson: Fix epoll detection

Peter Harris pharris at opentext.com
Mon Aug 14 21:10:07 UTC 2017


On 2017-08-14 4:45 PM, Keith Packard wrote:
> Peter Harris <pharris at opentext.com> writes:
>> -#if !HAVE_OSPOLL && HAVE_EPOLL_CREATE1
>> +#if !HAVE_OSPOLL && defined(HAVE_EPOLL_CREATE1)
> 
> Should be using defined for HAVE_OSPOLL as well?

HAVE_OSPOLL is only defined inside this file, not by autoconf/meson, so
it's always defined to 1.

The rest of os/ospoll.c uses #if instead of #ifdef everywhere. I'd be
inclined to update all of them if I were to paint that particular bikeshed.

Peter Harris
-- 
               Open Text Connectivity Solutions Group
Peter Harris                    http://connectivity.opentext.com/
Research and Development        Phone: +1 905 762 6001
pharris at opentext.com            Toll Free: 1 877 359 4866


More information about the xorg-devel mailing list