[PATCH xserver 1/9] First round of meson fixes

Eric Anholt eric at anholt.net
Thu Apr 27 19:00:21 UTC 2017


Adam Jackson <ajax at redhat.com> writes:

> This fixes the dmx build, and builds the rest of the Xorg loadables.
>
> I kind of wish static library targets would accept an empty file list,
> I think the 'if srcs_libc.length() > 0' trick in os/meson.build is a
> bit ugly. Ah well, the fact that you can then pass it as a link_with to
> another static library and have it work like you expect makes up for it.

I'd say that pattern was the hardest thing to adjust to with meson, for
me.

One whitespace comment, two optional changes, otherwise it's all:

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20170427/324ae6c6/attachment.sig>


More information about the xorg-devel mailing list