[PATCH xserver 3/3] Add a Meson build system alongside autotools.

[Peter Hutterer]

On Tue, Apr 25, 2017 at 04:03:01PM -0700, Eric Anholt wrote:
> This is a work in progress that builds Xvfb, Xephyr, Xwayland, Xnest,
> and Xdmx so far.  The outline of Xquartz/Xwin support is in tree, but
> hasn't been built yet.  The unit tests are also not done.
> 
> The intent is to build this as a complete replacement for the
> autotools system, then eventually replace autotools.  meson is faster
> to generate the build, faster to run the bulid, shorter to write the
> build files in, and less error-prone than autotools.

Replying with a few nits, because inline would be insane and I'm too lazy to cut it
properly:

a few tab/space indentation errors:
 hw/xfree86/loader/symbol-test.c
 hw/xquartz/meson.build


move this to the top of the file to make it easy to find:
 +major = 1
 +minor = 19
 +patch = 99
 +subpatch = 1

you could also set this as the project version and use split() to get to the
components. That seems the most obvious one from a maintainer's POV.

 +version_data.set_quoted('VENDOR_NAME', 'The X.Org Foundation')
shouldn't these come from get_option too?

That's all I could find on the first read. It builds locally and I think
merging this in and fixing it is the way to go. Since we leave automake this
can just sit on the side with no effects on current users, so
    Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>
for the series

Cheers,
   Peter