[PATCH xserver 3/7] hw/xfree86: add suid wrapper to uninstall target

Emil Velikov emil.l.velikov at gmail.com
Mon Apr 3 12:06:05 UTC 2017


On 1 April 2017 at 07:52, Mihail Konev <k.mvc at ya.ru> wrote:
> Signed-off-by: Mihail Konev <k.mvc at ya.ru>
> ---
> Not that this matters, but makes the distcheck not to fail.
>
>  hw/xfree86/Makefile.am | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/xfree86/Makefile.am b/hw/xfree86/Makefile.am
> index 85bd0bed0e58..00f0ee116d68 100644
> --- a/hw/xfree86/Makefile.am
> +++ b/hw/xfree86/Makefile.am
> @@ -120,6 +120,7 @@ endif
>
>  uninstall-hook:
>         $(AM_V_at)rm -f $(DESTDIR)$(bindir)/X
> +       $(AM_V_at)rm -f $(DESTDIR)$(SUID_WRAPPER_DIR)/Xorg
>
SUID_WRAPPER_DIR is not set when SUID_WRAPPER != yes.
Might be better to have something like the following:

if SUID_WRAPPER
uninstall-hook:
       $(AM_V_at)rm -f $(DESTDIR)$(SUID_WRAPPER_DIR)/Xorg
else
uninstall-hook:
       $(AM_V_at)rm -f $(DESTDIR)$(bindir)/X
endif

-Emil


More information about the xorg-devel mailing list