[xserver, 2/2] xf86RandR12: Fix XF86VidModeSetGamma triggering a BadImplementation error

Hans de Goede hdegoede at redhat.com
Tue Sep 27 10:26:34 UTC 2016


On 25-09-16 09:51, Michel Dänzer wrote:
> On 23/09/16 07:48 PM, Hans de Goede wrote:
>> On 09/23/2016 11:13 AM, Michel Dänzer wrote:
>>> On 23/09/16 03:46 PM, Hans de Goede wrote:
>>>> Since this is a fallback which ideally should never get used (all
>>>> drivers should call xf86HandleColormaps) I believe it is not worth
>>>> the time to implement your (admittedly better) fallback suggestion.
>>> Fine with me, but please at least change the comment to be more accurate
>>> and clearer.
>> OK, the comment now reads:
>> /*
>>  * Compatibility pScrn->ChangeGamma provider for ddx drivers which do
>> not call
>>  * xf86HandleColormaps(). Note such drivers really should be fixed to call
>>  * xf86HandleColormaps() as this clobbers any per-crtc setup.
>>  */
> As I mentioned before, "clobbers any per-CRTC setup" isn't accurate.
> Only the gamma ramp of the CRTC assigned to the RandR compatibility
> output is clobbered.

Ah I missed you had provided an improved comment and rolled my own.

I've fixed this in my personal tree now, and the fixed version
will be part of the updated pull-req for 1.19 I'm preparing.



More information about the xorg-devel mailing list