[PATCH xserver v3 02/11] glamor: Require that pixmap depths match for Render copies.

Michel Dänzer michel at daenzer.net
Mon Sep 26 01:37:55 UTC 2016

On 26/09/16 05:30 AM, Eric Anholt wrote:
> The copy optimization in d37329cba42fa8e72fe4be8a7be18e512268b5bd
> replicated a bug from last time we did a copy optimization: CopyArea
> is only defined for matching depths.  This is only a problem at 15 vs
> 16bpp right now (24 vs 32 would also have matching Render formats but
> they should work) but be strict in case we store other bpps
> differently in the future.

Nitpick: s/bpp/depth/g

> Fixes rendercheck -t blend -o src -f x4r4g4b4,x3r4g4b4
> v2: Drop excessive src->depth == dst->depth check that snuck in.
> v3: Switch back to src->depth == dst->depth
> Signed-off-by: Eric Anholt <eric at anholt.net>

Regardless of the above, patches 1-3 are

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>

Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

More information about the xorg-devel mailing list