[PATCH xserver v3 09/11] test: Update piglit HTML even when tests all pass.

Eric Anholt eric at anholt.net
Sun Sep 25 20:30:20 UTC 2016


I was confused by the behavior I'd written before.  keithp and
mattst88 responded with shock that I would have made it so surprising,
as well.

v2: Point to index.html instead of problems.html, which won't exist if
    we had no problems.

Signed-off-by: Eric Anholt <eric at anholt.net>
---
 test/scripts/run-piglit.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/test/scripts/run-piglit.sh b/test/scripts/run-piglit.sh
index c412d7ee70af..3623a05c17fd 100755
--- a/test/scripts/run-piglit.sh
+++ b/test/scripts/run-piglit.sh
@@ -66,15 +66,15 @@ if ! grep "^ *crash: *0$" $SHORT_SUMMARY > /dev/null; then
     status=1
 fi
 
-if test $status != 0; then
-    $PIGLIT_DIR/piglit-summary-html.py \
+$PIGLIT_DIR/piglit-summary-html.py \
 	--overwrite \
 	$PIGLIT_RESULTS_DIR/html \
 	$PIGLIT_RESULTS_DIR
 
+if test $status != 0; then
     echo "Some piglit tests failed."
     echo "The list of failing tests can be found in $LONG_SUMMARY."
-    echo "An html page of the failing tests can be found at $PIGLIT_RESULTS_DIR/html/problems.html"
 fi
+echo "An html page of the test status can be found at $PIGLIT_RESULTS_DIR/html/index.html"
 
 exit $status
-- 
2.9.3



More information about the xorg-devel mailing list