[PATCH xf86-input-libinput] Fix --with-xorg-conf-dir default value

Peter Hutterer peter.hutterer at who-t.net
Wed Sep 21 09:04:02 UTC 2016


On Wed, Sep 21, 2016 at 04:17:00PM +0900, Michel Dänzer wrote:
> On 21/09/16 03:49 PM, Peter Hutterer wrote:
> > On Fri, Sep 16, 2016 at 05:26:06PM +0900, Michel Dänzer wrote:
> >> From: Michel Dänzer <michel.daenzer at amd.com>
> >>
> >> If --prefix isn't specified on the command line, $prefix contains "NONE"
> >> at this point, not the default prefix value. So make install would
> >> attempt to install the xorg.conf.d snippet to
> >> ${DESTDIR}NONE/share/X11/xorg.conf.d/.
> >>
> >> Avoid this by leaving ${prefix} verbatim in the default value, to be
> >> resolved by make.
> >>
> >> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
> > 
> > what system was this on?
> 
> Debian sid with autoconf 2.69.
> 
> 
> > my fedora here seems to fill in the /usr/local prefix automatically
> > and early enough that this isn't an issue.
> 
> Can you find out where that happens for you?
> 
> Grepping for xNONE in /usr/share/autoconf here, I find that AC_OUTPUT in
> /usr/share/autoconf/autoconf/status.m4 checks for $prefix containing
> NONE and assigns $ac_default_prefix to it in that case. There are other
> macros which check for NONE and use $ac_default_prefix in that case.

can't quite find where it's expanded but after digging through the generated
configure script I concur with the commit message. so...

      b87d253..0cfe9ec  master -> master

thanks

Cheers,
   Peter


More information about the xorg-devel mailing list