[PATCH 1/1] dix: Hold the input_lock() when accessing the miEventQueue through checkForInput

Keith Packard keithp at keithp.com
Mon Sep 19 16:52:16 UTC 2016


Jeremy Huddleston Sequoia <jeremyhu at apple.com> writes:

> Yeah, I made the change mainly to shutup the analyzer while I was
> looking for other races.  I decided to propose it in case we want to
> be strict here.

Thanks. Keeping our request processing overhead low seems important
enough to me that we should skip this patch, although perhaps adding a
comment before the test noting that we are intentionally not holding the
input lock.

Is there some way we can annotate the code to silence the analyzer in
these cases?

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 800 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160919/7d6c4abd/attachment.sig>


More information about the xorg-devel mailing list