[PATCH 2/2] os/connection: Remove NewOutputPending

Keith Packard keithp at keithp.com
Sun Sep 18 15:51:20 UTC 2016


Jeremy Huddleston Sequoia <jeremyhu at apple.com> writes:

> Use any_output_pending() instead.

These aren't equivalent -- NewOutputPending is set when there is output
pending and we haven't detected that all of the clients with output
are blocked.

There's a patch for a bug in FlushAllOutput to set NewOutputPending when
we skip a client that has pending input. I attached that to my previous
message in this thread.

I think an alternative would be to remove write blocked clients from the
output pending list and re-add them when they became writable
again. Then we could use any_output_pending() instead of NewOutputPending.

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 800 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160918/cb0f914a/attachment.sig>


More information about the xorg-devel mailing list