[PATCH xf86-input-libinput] Initializing strip association with wrong index

Keith Packard keithp at keithp.com
Fri Sep 16 17:18:31 UTC 2016


This looks like a cut&paste coding error to me, and it generated a
compiler warning about possibly uninitialized value.

Signed-off-by: Keith Packard <keithp at keithp.com>
---
 src/xf86libinput.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/xf86libinput.c b/src/xf86libinput.c
index 888ba21..21f87f5 100644
--- a/src/xf86libinput.c
+++ b/src/xf86libinput.c
@@ -4537,7 +4537,7 @@ LibinputInitModeGroupProperties(DeviceIntPtr dev,
 	nstrips = libinput_device_tablet_pad_get_num_strips(device);
 	if (nstrips) {
 		for (s = 0; s < nstrips; s++) {
-			associations[r] = -1;
+			associations[s] = -1;
 			for (g = 0; g < ngroups; g++) {
 				group = libinput_device_tablet_pad_get_mode_group(device, g);
 				if (libinput_tablet_pad_mode_group_has_strip(group, s)) {
-- 
2.9.3



More information about the xorg-devel mailing list