PATCH bitmap-1.0.8:fix num_lock bug

walter harms wharms at bfs.de
Tue Sep 6 17:12:01 UTC 2016


hello list,

same time ago the user Frederic Baldit complained (on xorg) that
the ability to set single dots in the programm Bitmap depend on the state
of num_lock. This is a long standing bug that affect all versions
of bitmap.

the problem was that the corresponding function was erroneously checking
event->xbutton.state. Removing that check solved the problem for the user.

Signed-off-by: wharms <wharms at bfs.de>


----
--- Handlers.c.org      2016-09-06 18:58:10.000000000 +0200
+++ Handlers.c  2016-09-06 18:58:22.000000000 +0200
@@ -67,7 +67,6 @@
     switch (event->type) {

     case ButtonPress:
-       if (event->xbutton.state != status->state) return;
        if (!QuerySet(status->at_x, status->at_y)) {
            BWStoreToBuffer(w);
            status->value = Value(BW, event->xbutton.button);


More information about the xorg-devel mailing list