[PATCH v4 xserver 0/4] modesetting: add DRI2 page flip support

[Kenneth Graunke]

On Monday, August 22, 2016 6:14:14 PM PDT Qiang Yu wrote:
> Hi guys,
> 
> This patch set is for adding DRI2 page flip support to modesetting
> driver. I mainly take reference of amdgpu DDX and reuse present
> page flip code in the modesetting driver.
> 
> V2:
> 1. fix DRI2 page flip success handler event memory leak
> 2. adjust patch sequence to make DRI2 use the common
>    page flip code in pageflip.c from the beginning
> 3. some fix on debug output and comments
> 
> V3:
> 1. squash previous patch 5 into patch 4
> 
> V4:
> 1. fix ms_dri2_exchange_buffers width/height miss copy
> 2. some fix on debug output and comments
> 
> Regards,
> Qiang
> 
> Qiang Yu (4):
>   modesetting: make ms_do_pageflip generic for share with DRI2
>   modesetting: move ms_do_pageflip to pageflip.c
>   modesetting: move common page flip handle to pageflip.c
>   modesetting: add DRI2 page flip support
> 
>  hw/xfree86/drivers/modesetting/Makefile.am       |   1 +
>  hw/xfree86/drivers/modesetting/dri2.c            | 237 +++++++++++++++-
>  hw/xfree86/drivers/modesetting/driver.h          |  21 ++
>  hw/xfree86/drivers/modesetting/drmmode_display.h |   3 +
>  hw/xfree86/drivers/modesetting/pageflip.c        | 344 +++++++++++++++++++++++
>  hw/xfree86/drivers/modesetting/present.c         | 335 +++-------------------
>  6 files changed, 630 insertions(+), 311 deletions(-)
>  create mode 100644 hw/xfree86/drivers/modesetting/pageflip.c

Why add DRI2 page flipping support at all?  I intentionally omitted it
in the first place because this code is already tricky enough to get
right, and it seems strange to add a bunch of extra complexity for
legacy technology.  It's also another configuration we have to
support and debug.

For that matter, why not delete DRI2 support entirely at this point?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160905/150edf4a/attachment-0001.sig>