[PATCH xserver 2/4] xfree86: clarify xf86CallDriverProbe()'s effect on "xf86GPUScreens"
Hans de Goede
hdegoede at redhat.com
Sun Sep 4 08:54:15 UTC 2016
Hi,
On 04-09-16 03:11, Laszlo Ersek wrote:
> The "autoAddGPU" server flag (added in commit 74b786f7cee5) enables
> xf86CallDriverProbe() to extend the "xf86GPUScreens" array as well. Update
> the call site comment in xf86BusConfig() accordingly.
>
> Cc: Adam Jackson <ajax at redhat.com>
> Cc: Dave Airlie <airlied at redhat.com>
> Cc: Keith Packard <keithp at keithp.com>
> Signed-off-by: Laszlo Ersek <lersek at redhat.com>
Looks good to me:
Reviewed-by: Hans de Goede <hdegoede at redhat.com>
> ---
> hw/xfree86/common/xf86Bus.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/xfree86/common/xf86Bus.c b/hw/xfree86/common/xf86Bus.c
> index 5b93940a2dbe..dc83e2dde099 100644
> --- a/hw/xfree86/common/xf86Bus.c
> +++ b/hw/xfree86/common/xf86Bus.c
> @@ -119,9 +119,9 @@ xf86BusConfig(void)
> int i, j;
>
> /*
> - * Now call each of the Probe functions. Each successful probe will
> - * result in an extra entry added to the xf86Screens[] list for each
> - * instance of the hardware found.
> + * Now call each of the Probe functions. Each successful probe will result
> + * in an extra entry added to the xf86Screens[] list, or -- optionally --
> + * to the xf86GPUScreens[] list, for each instance of the hardware found.
> */
> for (i = 0; i < xf86NumDrivers; i++) {
> xf86CallDriverProbe(xf86DriverList[i], FALSE);
>
More information about the xorg-devel
mailing list