[PATCH 3/3] configure.ac: remove --enable-aiglx option

[Emil Velikov]

On Friday, 7 October 2016, Jon Turney <jon.turney at dronecode.org.uk> wrote:

> On 06/10/2016 19:15, Emil Velikov wrote:
>
>> On 6 October 2016 at 19:02, Jon Turney <jon.turney at dronecode.org.uk>
>> wrote:
>>
>>> On 29/09/2016 18:41, Emil Velikov wrote:
>>>
>>>>
>>>> Presently the option guards both direct and accelerated indirect GLX. As
>>>> such when one toggles it off they end up without any acceleration.
>>>>
>>>> Remove the option all together until we have the time to split/rework
>>>> things.
>>>>
>>>> Cc: Jon Turney <jon.turney at dronecode.org.uk>
>>>> Cc: Adam Jackson <ajax at redhat.com>
>>>> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
>>>> ---
>>>> Jon, I've not checked the Xwin side of things but considering that the
>>>> option is enabled by default and having it for Xwin only will be
>>>> confusing I've nuked the guards throughout the tree.
>>>>
>>>
>>> Sorry I didn't get around to testing this before it was committed.
>>>
>>> This breaks my build (See [1]), as the DRI2 loader is now built
>>> unconditionally, which fails without drm.h
>>>
>>> I'm not sure exactly what problem this change is fixing, so I'm not sure
>>> how
>>> to address that.
>>>
>>> Is it ok to restore the part which makes building the DRI2 loader
>>> conditional?
>>>
>>> I had a bad feeling about this, fortunately it seems pretty easy to
>> handle.
>>
>> From a quick look nothing in glx/glxdri2.c should require libdrm so we
>> can nuke the drm.h and xf86drm.h includes, which will get you back up
>> and going. Alternatively we can add those in a ifdef WITH_LIBDRM/endif
>> block.
>>
>
> That's not quite enough, as building glxdri2.c also requires dri2proto
> headers.
>
> At the moment, configure.ac only requires dri2proto when --enable-dri2
> turns on.
>
> So either that needs to be made unconditional, or building glxdri2.c made
> conditional on DRI2 (untested patch attached)
>
> You're correct. Wrapping it in DRI2 conditional is a good idea.

Note creating an empty (no sources or static libs) library is likely to
cause problems. Just use the form prior to my patch ?

Emil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.x.org/archives/xorg-devel/attachments/20161009/b4746dce/attachment.html>