[tigervnc-devel] PATCH: Add xorg-xserver 1.19 support to tigervnc

[Pierre Ossman]

On 03/10/16 17:59, Hans de Goede wrote:
> Hello tigervnc devs,
>
> As part of updating Fedora to xserver 1.19 I've written
> a tiger vnc patch to make tigervnc work with xserver 1.19.
>

Nice, Thanks. :)

> Since xserver 1.19 switches from select to poll the changes
> are non trivial and require some #ifdef-s. The new code is
> a lot cleaner then the old code though, which is good.
>
> And with server 1.19 the os/WaitFor.c changes are no longer
> necessary.
>

Very nice. However I'm not a fan of the large amount of duplicate code 
we're dragging around now. I'd prefer to switch everything over to the 
new model, and put something in vncBlockHandler.c that emulates the new 
API on top of the old system.

> Attached is a tigervnc-1.7.0 patch, as well as a patch
> to apply to the xserver sources to patch in the tigervnc
> ext and hw/vnc dir into the buidlsys.
>

> +#include "os.h"

NAK on this I'm afraid. Using Xorg headers in C++ has been endless 
grief. Hence the wrappers in both directions. I'd say put this in 
vncBlockHandler.c and tie it up via vncExtInit.cc.

> +  SetNotifyFd(sock->getFd(), HandleSocketFd, X_NOTIFY_READ, this);

I don't see any code setting X_NOTIFY_WRITE?

> --- xserver/include/os.h~	2016-10-03 09:07:29.000000000 +0200
> +++ xserver/include/os.h	2016-10-03 14:13:00.013654506 +0200
> @@ -621,7 +621,7 @@
>  extern _X_EXPORT void
>  LogClose(enum ExitCode error);
>  extern _X_EXPORT Bool
> -LogSetParameter(LogParameter param, int value);
> +LogSetParameter(enum _LogParameter param, int value);
>  extern _X_EXPORT void
>  LogVWrite(int verb, const char *f, va_list args)
>  _X_ATTRIBUTE_PRINTF(2, 0);

Is this a fix that's meant to go upstream at some point?

Regards
-- 
Pierre Ossman           Software Development
Cendio AB		https://cendio.com
Teknikringen 8		https://twitter.com/ThinLinc
583 30 Linköping	https://facebook.com/ThinLinc
Phone: +46-13-214600	https://plus.google.com/+CendioThinLinc

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?