[PATCH xts] xts5: Fix clang warning - non-void function 'outfile' should return a value

Peter Hutterer peter.hutterer at who-t.net
Sun Nov 20 21:08:58 UTC 2016


On Sun, Nov 13, 2016 at 01:50:49PM -0500, Rhys Kidd wrote:
> files.c:267:3: error: non-void function 'outfile' should return a value
>       [-Wreturn-type]
>                 return;
>                 ^
> 
> Signed-off-by: Rhys Kidd <rhyskidd at gmail.com>
> ---
>  xts5/src/bin/mc/files.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xts5/src/bin/mc/files.c b/xts5/src/bin/mc/files.c
> index ee88a40..a9198e1 100644
> --- a/xts5/src/bin/mc/files.c
> +++ b/xts5/src/bin/mc/files.c
> @@ -236,7 +236,7 @@ char *tmpfile;
>   * Combine all the files in the right order onto
>   * stdout.
>   */
> -outfile(fp)
> +void outfile(fp)
>  FILE	*fp;
>  {
>  static FILE	*fout;
> -- 
> 2.9.3

looks like something is missing here:

files.c: At top level:
files.c:239:6: error: conflicting types for ‘outfile’
 void outfile(fp)
       ^~~~~~~
In file included from mc.h:231:0,
                 from files.c:128:
mcproto.h:108:5: note: previous declaration of ‘outfile’ was here
 int outfile(FILE *fp);


Cheers,
   Peter


More information about the xorg-devel mailing list