[PATCH xserver 1/2] xwayland: Move sprite invalidation logic into mipointer

Emil Velikov emil.l.velikov at gmail.com
Sun May 29 10:44:24 UTC 2016

On 20 May 2016 at 05:25, Keith Packard <keithp at keithp.com> wrote:

>>> +/* Invalidate current sprite, forcing reload on next
>>> + * sprite setting (window crossing, grab action, etc)
>>> + */
>>> +extern _X_EXPORT void
>>> +miPointerInvalidateSprite(DeviceIntPtr pDev);
>>> +
>> It doesn't look like this should be exported, should it ?
> Yes, it's part of the server API and replaces the public definition of
> the underlying structure.
Slightly confused here - are you saying "yes, it should be exported"
or "yes, it shouldn't be". I'm leaning on the latter for a few
 - Xwayland (and everyone else but Xorg) does not use external modules
(libexa, libwfb, xf86-video-foo) thus there's no user for these
exports. Or any symbols for that matter ?
 - Seems like the exports from mi/ are remnants from the separate
(non-builtin) extmod days.

Not 100% sure though. Can anyone please shed some light ?


More information about the xorg-devel mailing list