[PATCH xserver] glamor: Cannot use copies when accessing outside of composite source

[Michel Dänzer]

On 26.05.2016 21:55, Hans de Goede wrote:
> On 26-05-16 12:04, Michel Dänzer wrote:
>> From: Michel Dänzer <michel.daenzer at amd.com>
>>
>> Commit b64108fa ("glamor: Check for composite operations which are
>> equivalent to copies") failed to copy conditions from exaComposite which
>> ensure that the composite operation doesn't access outside of the source
>> picture.
>>
>> This fixes rendercheck regressions from the commit above.
>>
>> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
> 
> I was hoping that this fixed the thunderbird regressions I was seeing
> after commit b64108fa, but unfortunately it does not.
> 
>> Apologies for jumping the gun on the previous patch by submitting it
>> without appropriate testing with rendercheck.
>>
>> There is one regression left with this patch (blend test on a8), that
>> one is fixed by https://patchwork.freedesktop.org/patch/87222/ .
> 
> I've added that one to my local master clone too, still not fixed.
> 
> The problem is that thunderbird and any thunderbird dialogs simply
> show up as completely gray windows without anything in them.
> 
> Reproducing is as simple as starting thunderbird.
> 
> I'm seeing this on a skylake system using the igpu with modesetting +
> glamor.
> 
> For now I'm running xserver-master with b64108fa reverted, let me know
> if you need to me test any potential fixes for this.

Does Keith's commit 8b9b4387 ("glamor: Adjust for drawable x/y in
composite's copy optimization") fix this (possibly combined with this
patch)?


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer