[PATCH xserver 17/23] os: Add ospoll interface

Emil Velikov emil.l.velikov at gmail.com
Fri May 27 21:28:39 UTC 2016


Hi Keith,

Style question: do you/how many others refer having separate functions for
of ifdeffed code each vs a single with all the ifdeffs. Or in other words
having func_foo_poll and func_foo_epoll as opposed to having it all in
func_foo.

On Friday, 27 May 2016, Keith Packard <keithp at keithp.com> wrote:

+#ifndef _OSPOLL_H_
> +#define _OSPOLL_H_
> +
> +#include <poll.h>
> +

This include should be in the C file with proper ifdef guard, right?

Emil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160527/237ffe62/attachment.html>


More information about the xorg-devel mailing list