[PATCH xserver 3/4] dix: Convert ResourceClientBits to a variable
keithp at keithp.com
Thu May 26 06:42:28 UTC 2016
Mark Kettenis <mark.kettenis at xs4all.nl> writes:
> Hmm. This is marked as _X_EXPORT, so presumably part of the driver
> ABI. Exporting variables like this is generally a bad idea, at least
> for ELF DSOs. Copy relocations and all that.
even libc exposes a pile of data, including stdin, stderr and stdout,
and that seems to work just fine.
Switching this from a #define to a exported variable makes the change
minimally invasive while solving the problem nicely. Anything more
complicated will be harder to understand and end up slower than this
solution. I don't see any benefit there.
Reviewed-by: Keith Packard <keithp at keithp.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 810 bytes
Desc: not available
More information about the xorg-devel