[PATCH xserver] glamor: Check for composite operations which are equivalent to copies

Alex Deucher alexdeucher at gmail.com
Wed May 25 13:24:00 UTC 2016


On Wed, May 25, 2016 at 6:09 AM, Michel Dänzer <michel at daenzer.net> wrote:
> From: Michel Dänzer <michel.daenzer at amd.com>
>
> Increases x11perf -compwinwin500 numbers by a factor of 10 for me with
> radeonsi.
>
> Conditions copied from exaComposite().
>
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  glamor/glamor_render.c | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/glamor/glamor_render.c b/glamor/glamor_render.c
> index 65f7059..33091c1 100644
> --- a/glamor/glamor_render.c
> +++ b/glamor/glamor_render.c
> @@ -1394,6 +1394,29 @@ glamor_composite_clipped_region(CARD8 op,
>      DEBUGF("clipped (%d %d) (%d %d) (%d %d) width %d height %d \n",
>             x_source, y_source, x_mask, y_mask, x_dest, y_dest, width, height);
>
> +    /* Is the composite operation equivalent to a copy? */
> +    if (!mask && !source->alphaMap && !dest->alphaMap
> +        && source->pDrawable && !source->transform
> +        && ((op == PictOpSrc
> +             && ((source->format == dest->format
> +                  || (PICT_FORMAT_COLOR(dest->format)
> +                      && PICT_FORMAT_COLOR(source->format)
> +                      && dest->format == PICT_FORMAT(PICT_FORMAT_BPP(source->format),
> +                                                     PICT_FORMAT_TYPE(source->format),
> +                                                     0,
> +                                                     PICT_FORMAT_R(source->format),
> +                                                     PICT_FORMAT_G(source->format),
> +                                                     PICT_FORMAT_B(source->format))))
> +                 || (op == PictOpOver
> +                     && source->format == dest->format
> +                     && !PICT_FORMAT_A(source->format)))))) {
> +        glamor_copy(source->pDrawable, dest->pDrawable, NULL,
> +                    box, nbox, x_source - x_dest,
> +                    y_source - y_dest, FALSE, FALSE, 0, NULL);
> +        ok = TRUE;
> +        goto out;
> +    }
> +
>      /* XXX is it possible source mask have non-zero drawable.x/y? */
>      if (source
>          && ((!source->pDrawable
> --
> 2.8.1
>
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: https://lists.x.org/mailman/listinfo/xorg-devel


More information about the xorg-devel mailing list