[PATCH xserver 3/9] xfree86: Remove unnecessary errno save/restore in xf86ReadInput

Peter Hutterer peter.hutterer at who-t.net
Mon May 16 05:18:53 UTC 2016


On Wed, May 11, 2016 at 01:54:52PM -0700, Keith Packard wrote:
> When this code was called from SIGIO, saving and restoring errno could
> possibly have made sense in some strange environment. Now that this
> will not be called from a signal handler, there is no reason to do that.
> 
> Signed-off-by: Keith Packard <keithp at keithp.com>

Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>

Cheers,
   Peter

> ---
>  hw/xfree86/common/xf86Events.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/hw/xfree86/common/xf86Events.c b/hw/xfree86/common/xf86Events.c
> index 81416ed..df8c7b6 100644
> --- a/hw/xfree86/common/xf86Events.c
> +++ b/hw/xfree86/common/xf86Events.c
> @@ -298,12 +298,9 @@ xf86Wakeup(void *blockData, int err, void *pReadmask)
>  static void
>  xf86ReadInput(int fd, int ready, void *closure)
>  {
> -    int errno_save = errno;
>      InputInfoPtr pInfo = closure;
>  
>      pInfo->read_input(pInfo);
> -
> -    errno = errno_save;
>  }
>  
>  /*
> -- 
> 2.8.0.rc3
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: https://lists.x.org/mailman/listinfo/xorg-devel
> 


More information about the xorg-devel mailing list