[PATCH libICE] Enable visibility annotations

[Emil Velikov]

On 13 May 2016 at 07:33, Yury Gribov <y.gribov at samsung.com> wrote:
> On 05/10/2016 03:00 PM, Yury Gribov wrote:
>>
>> On 05/06/2016 07:25 PM, Alan Coopersmith wrote:
>>>
>>> On 05/ 6/16 04:18 AM, Yury Gribov wrote:
>>>>
>>>> Unfortunately I don't see any good approach. We could move
>>>> definitions of
>>>> _X_EXPORT and friends to configure.ac but this would need to be done
>>>> for all X11 packages (not just libICE) which just does not scale.
>>>
>>>
>>> And then you'd require any package that #includes an X11 header to use
>>> autoconf and add those to configure.ac and that really doesn't scale.
>>
>>
>> There is a way around this: you can strip internal defines from public
>> headers and replace it with e.g. extern. This is how visibility was
>> enabled for acl and libattr some time ago
>> (http://lists.nongnu.org/archive/html/acl-devel/2016-02/msg00020.html).
>>
>>> Xfuncproto.h exists because X exposes headers to things built with
>>> hundreds of different build systems.
>
>
> Cc-ed my home address (today's my last day in Samsung).
>
I'm sorry but I still don't see what/why you're suggesting. Can you
please elaborate ?

Related data point - both Sun/Oracle compiler and MSVC emit
warnings/errors, when the function definition is annotated with
_X_EXPORT, but the declaration isn't.


-Emil