[PATCH xserver] glamor: Disable logic ops when doing compositing

[Eric Anholt]

Keith Packard <keithp at keithp.com> writes:

> Eric Anholt <eric at anholt.net> writes:
>
>> Keith Packard <keithp at keithp.com> writes:
>>
>>> If the logic op gets left enabled, it overrides the blending
>>> operation, causing incorrect contents on the display.
>>>
>>> Signed-off-by: Keith Packard <keithp at keithp.com>
>>
>> Reviewed-by: Eric Anholt <eric at anholt.net>
>
> And it's actually wrong (sigh). Need to do this in all paths through
> this function (even the PictOpSrc case), and we only want to do it on
> non-ES2 flavors. Here's an updated version.
>
> From 1ac2ef66369f36ef132f643969ad176db39babe7 Mon Sep 17 00:00:00 2001
> From: Keith Packard <keithp at keithp.com>
> Date: Fri, 13 May 2016 04:25:43 -0700
> Subject: [PATCH xserver] glamor: Disable logic ops when doing compositing [v2]
>
> If the logic op gets left enabled, it overrides the blending
> operation, causing incorrect contents on the display.
>
> v2: Disable only on non-ES2, but disable even for PictOpSrc

Oh, yeah.  Even better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160513/a5a2ca44/attachment.sig>