[PATCH xserver] glamor: Disable logic ops when doing compositing

Alex Deucher alexdeucher at gmail.com
Fri May 13 14:09:38 UTC 2016


On Fri, May 13, 2016 at 7:29 AM, Keith Packard <keithp at keithp.com> wrote:
> If the logic op gets left enabled, it overrides the blending
> operation, causing incorrect contents on the display.
>
> Signed-off-by: Keith Packard <keithp at keithp.com>

Makes sense.
Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  glamor/glamor_program.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/glamor/glamor_program.c b/glamor/glamor_program.c
> index 0a94de6..a43ee6e 100644
> --- a/glamor/glamor_program.c
> +++ b/glamor/glamor_program.c
> @@ -499,6 +499,7 @@ glamor_set_blend(CARD8 op, glamor_program_alpha alpha, PicturePtr dst)
>      }
>
>      glEnable(GL_BLEND);
> +    glDisable(GL_COLOR_LOGIC_OP);
>      glBlendFunc(src_blend, dst_blend);
>  }
>
> --
> 2.8.0.rc3
>
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: https://lists.x.org/mailman/listinfo/xorg-devel


More information about the xorg-devel mailing list