[PATCH xserver] glamor: Disable logic ops when doing compositing

Markus Wick markus at selfnet.de
Fri May 13 11:40:24 UTC 2016


Hi,

AFAIK we disable logic ops after each usage, so this seems a bit 
redundant to me. Did we miss one usages? As logic ops aren't very 
common, this sounds good to me.

Am 2016-05-13 13:29, schrieb Keith Packard:
> If the logic op gets left enabled, it overrides the blending
> operation, causing incorrect contents on the display.
> 
> Signed-off-by: Keith Packard <keithp at keithp.com>
> ---
>  glamor/glamor_program.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/glamor/glamor_program.c b/glamor/glamor_program.c
> index 0a94de6..a43ee6e 100644
> --- a/glamor/glamor_program.c
> +++ b/glamor/glamor_program.c
> @@ -499,6 +499,7 @@ glamor_set_blend(CARD8 op, glamor_program_alpha
> alpha, PicturePtr dst)
>      }
> 
>      glEnable(GL_BLEND);
> +    glDisable(GL_COLOR_LOGIC_OP);
>      glBlendFunc(src_blend, dst_blend);
>  }



More information about the xorg-devel mailing list