[PATCH xserver 5/7] glx: Don't flush an arbitrary GL context from DrawableGone

Eric Anholt eric at anholt.net
Tue May 10 20:32:31 UTC 2016

Adam Jackson <ajax at redhat.com> writes:

> The current context at this point could be anything; we've done nothing
> to bind the context whose drawable is about to go away. There's not
> really much point in doing the flush anyway since any rendering is going
> to be thrown away, so just do nothing.
> Signed-off-by: Adam Jackson <ajax at redhat.com>

This reverts 5c606c0a89e74fa223a99864be11cc3be60a159b.  The commit seems
quite wrong, as you've pointed out, though.  I suspect that what that
commit should have done instead was catch a GLXBadCurrentWindow from
DoMakeCurrent's __glXForceCurrent() and just skip the glFlush() when it

We might want to slip in a better fix before this revert, and make the
revert explicit.  I'm OK with just reverting without the fix, though.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160510/6107c4ce/attachment.sig>

More information about the xorg-devel mailing list