[PATCH glx] glx: avoid memory leak when using indirect rendering

Adam Jackson ajax at nwnk.net
Mon May 9 19:41:22 UTC 2016

On Mon, 2016-04-04 at 19:57 +0000, Guilherme Melo wrote:
> Updated patch with some other places with a potential leak.

Apologies for being so slow to look at this.

Unfortunately I think it's incorrect.  lastGLContext is not necessarily
of __GLXcontext type - glamor sets it a glamor_ctx *, for example - so
passing it to ->loseCurrent isn't always going to work.

I think your first patch that only did the loseCurrent from
__glXForceCurrent was closer to correct.

- ajax

More information about the xorg-devel mailing list