[PATCH libICE 1/7] Added visibility annotations.

Adam Jackson ajax at nwnk.net
Mon May 9 16:52:08 UTC 2016

On Sun, 2016-05-08 at 09:19 +0100, Emil Velikov wrote:
> From: Yury Gribov <y.gribov at samsung.com>
> This allow us to be good citizen by hiding the private symbols and
> reducing the overall size of the binary.
> Note: _IceTransNoListen must be exported (albeit being a non-public
> symbol) as explained in the comment just above it.
> Signed-off-by: Yury Gribov <y.gribov at samsung.com>
> v2:
>  - Add commit message.
>  - Reuse existing CFLAGS
>  - Add a beefy comment about the _IceTransNoListen export.
> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>

The only question I have remaining here is how many version numbers we
should bump to reflect this change. I think I can be convinced that
bumping the soname isn't wholly necessary since clients were already
going off-label to get at this API in the first place, but it'd be nice
to see at least the package major number bumped so it's extremely
obvious where the break happened.

Assuming we do that, series is:

Reviewed-by: Adam Jackson <ajax at redhat.com>

- ajax

More information about the xorg-devel mailing list