[PATCH v2 xserver] EXA: Honour op parameter to exaGlyphs even if maskFormat == NULL

Michel Dänzer michel at daenzer.net
Fri May 6 06:47:29 UTC 2016


On 05.05.2016 22:30, Uli Schlachter wrote:
> Am 01.04.2016 um 11:24 schrieb Michel Dänzer:
>> From: Michel Dänzer <michel.daenzer at amd.com>
>>
>> Reported-by: Uli Schlachter <psychon at znc.in>
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94775
>> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
> 
> Ping? Does anyone with lots of clue about EXA want to take a look at this?
> 
> If it helps (since it's a step in the right direction and it becomes harder to
> get wrong rendering after this patch):

Assuming "wrong rendering" refers to this paragraph from the referenced
bug you reported:

 However, that could produce incorrect rendering with intermediate
 flushes and some operators that cannot easily split (e.g. Out).

That would be a client bug, the RENDER specification explicitly defines
how rendering is performed when mask-format is None.

So, this is quite certainly the correct fix.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the xorg-devel mailing list